[minor] add support to install MAS Provisioner #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caroazad
requested review from
durera,
andrercm,
sanjayprab,
terenceq,
whitfiea and
alequint
as code owners
caroazad
changed the title
whitfiea
requested changes
May 28, 2025
Comment on lines
+286
to
+310
| sm_update_secret $SECRET_NAME_PROVISIONER "{\"git_token\": \"${GITHUB_PAT}\"}" "${TAGS}" | ||
| else | ||
| export SECRET_KEY_GITHUB_TOKEN="" | ||
| fi | ||
|
|
||
| if [ -n "$PAGERDUTY_KEY" ]; then | ||
| echo "- Update PAGERDUTY_KEY secret" | ||
| TAGS="[{\"Key\": \"source\", \"Value\": \"gitops_mas_provisioner\"}, {\"Key\": \"account\", \"Value\": \"${ACCOUNT_ID}\"}, {\"Key\": \"cluster\", \"Value\": \"${CLUSTER_ID}\"}]" | ||
| sm_update_secret $SECRET_NAME_PROVISIONER "{\"pd_key\": \"${PAGERDUTY_KEY}\"}" "${TAGS}" | ||
| else | ||
| export SECRET_KEY_PAGERDUTY="" | ||
| fi | ||
|
|
||
| if [ -n "$OCM_API_KEY" ]; then | ||
| echo "- Update OCM_API_KEY secret" | ||
| TAGS="[{\"Key\": \"source\", \"Value\": \"gitops_mas_provisioner\"}, {\"Key\": \"account\", \"Value\": \"${ACCOUNT_ID}\"}, {\"Key\": \"cluster\", \"Value\": \"${CLUSTER_ID}\"}]" | ||
| sm_update_secret $SECRET_NAME_PROVISIONER "{\"ocm_api\": \"${OCM_API_KEY}\"}" "${TAGS}" | ||
| else | ||
| export SECRET_KEY_OCM_API="" | ||
| fi | ||
|
|
||
| if [ -n "$CSB_CA_CERT" ]; then | ||
| echo "- Update CSB_CA_CERT secret" | ||
| TAGS="[{\"Key\": \"source\", \"Value\": \"gitops_mas_provisioner\"}, {\"Key\": \"account\", \"Value\": \"${ACCOUNT_ID}\"}, {\"Key\": \"cluster\", \"Value\": \"${CLUSTER_ID}\"}]" | ||
| sm_update_secret $SECRET_NAME_PROVISIONER "{\"cert\": \"${CSB_CA_CERT}\"}" "${TAGS}" |
There was a problem hiding this comment.
All these calls are updating the same secret, this will cause all the keys to be removed that were previously present i.e. if the CSB_CA_CERT is set then the secret will only have one key called cert and all the previous keys that might be set i.e. ocm_api etc will be lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to install MAS Provisioner/Service Broker via gitops/saas-envs